Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-856228 easy logging parser #924

Merged
merged 11 commits into from
Oct 13, 2023

Conversation

sfc-gh-knozderko
Copy link
Collaborator

@sfc-gh-knozderko sfc-gh-knozderko commented Oct 11, 2023

Description

Please explain the changes you made here.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner October 11, 2023 09:56
client_configuration.go Outdated Show resolved Hide resolved
client_configuration.go Outdated Show resolved Hide resolved
client_configuration.go Outdated Show resolved Hide resolved
client_configuration.go Outdated Show resolved Hide resolved
client_configuration.go Outdated Show resolved Hide resolved
client_configuration_test.go Show resolved Hide resolved
client_configuration_test.go Outdated Show resolved Hide resolved
client_configuration_test.go Outdated Show resolved Hide resolved
client_configuration_test.go Outdated Show resolved Hide resolved
client_configuration_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #924 (21daec9) into master (46bf297) will increase coverage by 0.01%.
The diff coverage is 86.04%.

@@            Coverage Diff             @@
##           master     #924      +/-   ##
==========================================
+ Coverage   83.22%   83.23%   +0.01%     
==========================================
  Files          48       49       +1     
  Lines        9244     9287      +43     
==========================================
+ Hits         7693     7730      +37     
- Misses       1551     1557       +6     
Files Coverage Δ
client_configuration.go 86.04% <86.04%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-dheyman
Copy link
Collaborator

test

client_configuration.go Outdated Show resolved Hide resolved
client_configuration_test.go Outdated Show resolved Hide resolved
client_configuration_test.go Outdated Show resolved Hide resolved
client_configuration_test.go Outdated Show resolved Hide resolved
client_configuration_test.go Outdated Show resolved Hide resolved
client_configuration_test.go Outdated Show resolved Hide resolved
@sfc-gh-knozderko sfc-gh-knozderko merged commit dfb1c18 into master Oct 13, 2023
23 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-856228_easy_logging_parser branch October 13, 2023 11:35
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants